Skip to content

Conversation

@dnephin
Copy link
Contributor

@dnephin dnephin commented Jan 17, 2018

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@tonistiigi
Copy link
Member

LGTM

@codecov-io
Copy link

Codecov Report

Merging #814 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   51.23%   51.21%   -0.02%     
==========================================
  Files         237      237              
  Lines       15399    15399              
==========================================
- Hits         7889     7887       -2     
- Misses       7008     7010       +2     
  Partials      502      502

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

looks like this changed between docker 1.5 and 1.6; moby/moby#36027 (comment)

@thaJeztah thaJeztah changed the title Improve buidler ENV docs Improve builder ENV docs Jan 17, 2018
@thaJeztah thaJeztah merged commit 4f55001 into docker:master Jan 17, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.02.0 milestone Jan 17, 2018
@dnephin dnephin deleted the fix-builder-env-docs branch January 17, 2018 22:28
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Improve builder ENV docs
Upstream-commit: 4f55001
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants